#1  
Old 2nd May 2015, 07:23 AM
corssa corssa is offline
Junior Member
 
Join Date: Oct 2012
Posts: 3
Default Translation reference bug

Tested on PJ 1.6 , 1.7 & 2.2

Only PJ 2.2 has this issue AFAIK (didn't test on other 2.x versions);

In the ROM browser, under the field "Good Name", normally the unknown ROMs not verified as good dumps/not present in the RDB, will show the following message(from line #340# in pj.lang files):

"Bad ROM? Use GoodN64 & check for updated RDB"

When the bug occurs, that message will be replaced by "#340#", as a line reference for the missing message(quoted above) which is supposedly in the selected/default pj.lang file for the emulator to use.

How to reproduce it:

1. Make sure you have a ROM in the ROM browser identified as unknown by the "Status" field.

2. Options > Settings... > ROM Selection > Change the order of the field Good Name to any different position other than the 1st.
Apply the changes.

3. Notice how you have "#340#" displaying instead of "Bad ROM? Use GoodN64 & check for updated RDB".



Note: This is reversible, you can go back to ROM Selection and put Good Name back to its original position.

Workaround: Don't move Good Name field from the 1st/default position.

Last edited by corssa; 2nd May 2015 at 01:44 PM. Reason: wrong line number
Reply With Quote
  #2  
Old 3rd May 2015, 10:08 AM
zilmar zilmar is offline
Core Team
Alpha Tester
Project Supporter
Administrator
 
Join Date: Jun 2005
Posts: 988
Default

your right, it would be only in 2.2 as it is using the #340# string to allow the change of language right away.

ok fixed this in this fix:
https://github.com/project64/project...960e478a30a8ab
Reply With Quote
  #3  
Old 3rd May 2015, 12:19 PM
corssa corssa is offline
Junior Member
 
Join Date: Oct 2012
Posts: 3
Default

Thank you.

I only know Java to a certain extent, but looking at that code change now I feel like I could have done it myself. Doesn't seem as difficult as I thought.
Maybe I will stay around and learn some things on emulation.
Reply With Quote
Reply

Tags
#340#, bug

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT. The time now is 01:09 PM.


Powered by vBulletin® Version 3.7.3
Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.