N-Rage plugin not saving C Buttons, all other buttons work

[bernhard43]

I'm having an issue with the N-Rage plugin not saving the C buttons when I assign them to my controller. Steps to reproduce the problem:

- Start with a fresh PJ64 2.3.2.202 install
- Plugin a controller (I tried both an Xbox 360 and Xbox One controller)
- Open the N-Rage input plugin settings
- Select XInput mode
- Map any controller button to one of the C buttons
- Click save, then close, then reopen the settings
- Expected result: C button is still mapped. Actual result: It's reset to "None".

The same is true for the D-pad. None of the D-pad directions will save. All other N64 buttons are saved correctly. This only happens in XInput mode.

I suspect it might be a bug in the GUI. When I map the C buttons and click save, I can see that the changes are actually written to the config file, and the C buttons are actually working in the game at that point. This part works. It seems to be the loading part that is broken. Only when I reopen the settings dialog, the mapping is reset. There seems to be an error in the routine that loads and displays the mappings from the config file. ("XInput Controller 1 Config.xcc")

[ExtremeDude2]

Might want to make an issue on github:

https://github.com/project64/project64/issues

[bernhard43]

Thanks, I just did that. Someone else already opened that issue and I posted my comment there.

github.com/project64/project64/issues/1256

Maybe I can try to fix the issue in the code and post it to GitHub. I have only basic programming knowledge, but hopefully, that shouldn't be too hard to fix.